Skip to content

[action] [PR:4658] [console] route connect CLI through in-process console_connect helper part 2#412

Merged
mssonicbld merged 1 commit into
Azure:202603from
mssonicbld:cherry/msft-202603/4658
Jul 16, 2026
Merged

[action] [PR:4658] [console] route connect CLI through in-process console_connect helper part 2#412
mssonicbld merged 1 commit into
Azure:202603from
mssonicbld:cherry/msft-202603/4658

Conversation

@mssonicbld

Copy link
Copy Markdown
Collaborator

part 2 of 4531
Replace the last pexpect with os.execvp / bash session script to improve picocom performance

What I did

added the second part of the change to streamline the picocom launch process

How I did it

replaced the second pexpect call with execvp

How to verify it

first, launch console app just like before
then, use ps -ef to make sure "connect line" is no longer a standalone process

New command output (if the output of a command-line utility has changed)

connect line X or just reverse ssh

Which release branch to backport (provide reason below if selected)

  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202603
  • 202605

Signed-off-by: Sonic Build Admin sonicbld@microsoft.com

… part 2

part 2 of 4531
Replace the last pexpect with os.execvp / bash session script to improve picocom performance

<!--
    Please make sure you've read and understood our contributing guidelines:
    https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

    ** Make sure all your commits include a signature generated with `git commit -s` **

    If this is a bug fix, make sure your description includes "closes #xxxx",
    "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
    issue when the PR is merged.

    If you are adding/modifying/removing any command or utility script, please also
    make sure to add/modify/remove any unit tests from the tests
    directory as appropriate.

    If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
    subcommand, or you are adding a new subcommand, please make sure you also
    update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
    your changes.

    Please provide the following information:
-->

#### What I did
added the second part of the change to streamline the picocom launch process
#### How I did it
replaced the second pexpect call with execvp
#### How to verify it
first, launch console app just like before
then, use ps -ef to make sure "connect line" is no longer a standalone process
#### New command output (if the output of a command-line utility has changed)
connect line X or just reverse ssh

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202603
- [x] 202605

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator Author

Original PR: sonic-net/sonic-utilities#4658

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@mssonicbld
mssonicbld merged commit 0d4c1bb into Azure:202603 Jul 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant